Skip to content

Remove retireignore file#348

Open
apodacaduron wants to merge 5 commits into
mainfrom
remove-retireignore-file
Open

Remove retireignore file#348
apodacaduron wants to merge 5 commits into
mainfrom
remove-retireignore-file

Conversation

@apodacaduron

@apodacaduron apodacaduron commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

We added this file because after we updated tinymce #347 pipeline was still failing, this was due to some outdated rules in retirejs package, they sent a fix so this file is not needed anymore

How to Test

RetireJS pipeline should pass

Jira ID (if applicable)

[e.g., BYNT-123]

@apodacaduron apodacaduron self-assigned this Jun 9, 2026
@apodacaduron apodacaduron requested a review from level09 as a code owner June 9, 2026 15:13
@coderabbitai

coderabbitai Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2b1dac88-f776-470c-9f8e-9bee0ccff507

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-retireignore-file

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

level09
level09 previously approved these changes Jul 1, 2026
View reviewed changes
@apodacaduron

apodacaduron commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I updated Tinymce to 8.7.0 but seems like the updated dompurify version will be release on 8.7.1 so this will remain blocked for now https://github.com/tinymce/tinymce/milestone/103?closed=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@level09 level09 level09 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@apodacaduron apodacaduron

Labels

project i

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apodacaduron @level09